Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Search Event when user presses Ctrl + K #804

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

penxian
Copy link
Contributor

@penxian penxian commented May 21, 2024

PR Checklist

  • The changes have been tested (for bug fixes / features).
  • Docs in NexT website have been added / updated (for features).

PR Type

  • Bugfix.
  • Feature.
  • Improvement.
  • Code style update (e.g. formatting, linting).
  • Refactoring (no changes to functionality and APIs).
  • Documentation.
  • Translation.
  • Other... Please describe:

What is the current behavior?

Issue resolved:
Search Services will support shortcut key ctrl + K

What is the new behavior?

  • Link to demo site with this changes:
  • Screenshots with this changes:
    动画3

How to use?

In NexT _config.yml:

Copy link

welcome bot commented May 21, 2024

Thanks so much for opening your first PR here!

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@penxian penxian changed the title When the user presses Ctrl + K will target Search Event When the user presses Ctrl + K will trigger Search Event May 21, 2024
@coveralls
Copy link

coveralls commented Jul 15, 2024

Pull Request Test Coverage Report for Build 10956269594

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.446%

Totals Coverage Status
Change from base Build 9517060757: 0.0%
Covered Lines: 400
Relevant Lines: 405

💛 - Coveralls

@stevenjoezhang
Copy link
Member

Thank you for your contribution. I have modified some of the code to support the Cmd+K shortcut on macOS.

@stevenjoezhang stevenjoezhang added this to the 8.20.1 milestone Sep 20, 2024
@stevenjoezhang stevenjoezhang changed the title When the user presses Ctrl + K will trigger Search Event Trigger Search Event when user presses Ctrl + K Sep 20, 2024
@stevenjoezhang stevenjoezhang merged commit 1b2b4f2 into next-theme:master Sep 20, 2024
12 of 13 checks passed
Copy link

welcome bot commented Sep 20, 2024

Congrats on merging your first pull request here! 🎉 How awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants