Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provide a useable typing file #266

Closed
wants to merge 2 commits into from
Closed

Conversation

Losses
Copy link

@Losses Losses commented Sep 5, 2021

The previous typescript definition contained some uncertain type descriptions and was inconsistent with the 0.7.0 version of flexsearch. This PR fixes those issues.

@Losses
Copy link
Author

Losses commented Sep 15, 2021

Closing this in favor of:
DefinitelyTyped/DefinitelyTyped#55698 (comment)

The type definition will be available on @types/flexsearch.

@Losses Losses closed this Sep 15, 2021
@liuhbin
Copy link

liuhbin commented Sep 15, 2021

Closing this in favor of:
DefinitelyTyped/DefinitelyTyped#55698 (comment)

The type definition will be available on @types/flexsearch.

Just what we needed, thanks for your work

@jarrodek
Copy link

Can you delete index.d.ts from this repository and publish the package without it?
While the file is in the package it has a priority over @types flexsearch.

@Losses
Copy link
Author

Losses commented Jan 14, 2023

Can you delete index.d.ts from this repository and publish the package without it? While the file is in the package it has a priority over @types flexsearch.

Maybe you can make a pull request for the author?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants