This repository has been archived by the owner on Jul 17, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fauna
@next-auth/fauna-adapter related
tests
Changes to testing
labels
Aug 16, 2021
pbteja1998
reviewed
Aug 16, 2021
packages/fauna/fauna/resources/indexes/user_by_provider_account_id.fql
Outdated
Show resolved
Hide resolved
pbteja1998
reviewed
Aug 16, 2021
packages/fauna/fauna/resources/indexes/user_by_provider_and_provider_account_id.fql
Outdated
Show resolved
Hide resolved
pbteja1998
reviewed
Aug 16, 2021
pbteja1998
approved these changes
Aug 16, 2021
ndom91
approved these changes
Aug 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well, man is fauna less inuitive though than prisma imo 😅 the prisma methods and object arguments "just make sense", where fauna seems super cryptic at times
Tests all passed, etc 🎉 I had some trouble initially though - had to delete my node_modules
and package-lock.json
a few times and remember to use node 16+ (randomUUID
) and then finally with node 16 and switching to yarn I was able to get it to run and all pass!!
This was referenced Aug 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #171, nextauthjs/next-auth#2361
TODO: Figure out how to cascade deletion of accounts and sessions:In the future, we would like to implement a "delete user" feature in NextAuth. We want to use thedeleteUser
adapter method for that. In addition to removing the actual User, we should remove any remaining user objects like the connected accounts and active sessions. I need help to figure out how to do that.cc @pbteja1998 Could you provide some guidance?Docs says:> There is no cascading delete for user-defined documents. If you have a document "A" that includes a reference to another document "B", deleting "A" does not affect "B", and deleting "B" does not affect "A". You would have to write your own query logic to automatically follow references to perform a cascading delete.https://docs.fauna.com/fauna/current/api/fql/functions/delete?lang=javascript