Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openid-client warnings on Node 18 #6650

Closed
nbouvrette opened this issue Feb 8, 2023 · 4 comments
Closed

openid-client warnings on Node 18 #6650

nbouvrette opened this issue Feb 8, 2023 · 4 comments
Labels
accepted The feature request is considered. If nobody works actively on it, feel free to. good first issue Good issue to take for first time contributors legacy Refers to `next-auth` v4. Minimal maintenance.

Comments

@nbouvrette
Copy link

Environment

It looks like #6137 was closed but Next 16 will be end of support in 7 months. Vercel also moved to Node 18 as the default version.

Can next-auth update openid-client so that we can stop having the warnings when installing next-auth?

Reproduction URL

N/A

Describe the issue

image

How to reproduce

Just run npm install when using Node 18 and using next-auth

Expected behavior

There should be no warning.
@nbouvrette nbouvrette added the triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. label Feb 8, 2023
@balazsorban44
Copy link
Member

Thought we addressed this already via f54424c

next-auth/packages/next-auth/package.json

Line 75 in f2e85c2

"openid-client": "^5.1.0",
should just be bumped.

@balazsorban44 balazsorban44 added good first issue Good issue to take for first time contributors accepted The feature request is considered. If nobody works actively on it, feel free to. legacy Refers to `next-auth` v4. Minimal maintenance. and removed triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Feb 8, 2023
@nbouvrette
Copy link
Author

@balazsorban44 hmm f54424c seems completely different, this is the change for next-auth's engine - the error in this issue is caused by openid-client's engine which they removed back last September in panva/node-openid-client@9aefba3.

Next-auth should use "openid-client": "^5.1.10", (not 5.1.0) or greater.

@balazsorban44
Copy link
Member

balazsorban44 commented Feb 9, 2023 •
edited
Loading

I get it. 🙂 I just wasn't aware we were behind on openid-client that still had engines. (The only reason next-auth had engines was to match openid-client).

@balazsorban44 balazsorban44 mentioned this issue Feb 9, 2023
Merged
@nbouvrette
Copy link
Author

Awesome, thanks for the quick turnaround!

@natashaannn natashaannn mentioned this issue Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted The feature request is considered. If nobody works actively on it, feel free to. good first issue Good issue to take for first time contributors legacy Refers to `next-auth` v4. Minimal maintenance.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nbouvrette @balazsorban44