Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update openid-client to latest version #6137

Closed
wants to merge 2 commits into from

Conversation

rafaelderolez
Copy link

@rafaelderolez rafaelderolez commented Dec 21, 2022

☕️ Reasoning

I've upgraded openid-client to the latest version to make sure that it supports Node 18 as discussed in this issue: #5639. The PR (#5656) that closed the issue only removed the engine restrictions on next-auth's end, but didn't upgrade the openid-client version.

The node versions for openid-client were updated in this commit: panva/openid-client@9aefba3 as part of release 5.1.10

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #5639 (but for real this time)

📌 Resources

@vercel
Copy link

vercel bot commented Dec 21, 2022

@rafaelderolez is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 23, 2022 at 10:35AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
next-auth ⬜️ Ignored (Inspect) Dec 23, 2022 at 10:35AM (UTC)

@piersolenski

This comment was marked as spam.

@panva
Copy link
Contributor

panva commented Dec 25, 2022

^5.1.0 (current openid-client dependency range) does not preclude from getting the latest openid-client version. Just run npm upgrade (or whatever package manager alternative) to update your dependency tree.

@rafaelderolez
Copy link
Author

@panva My mistake then. Thanks for the quick reply & happy holidays!

@mschipperheyn
Copy link

This is not a good solution. By default using yarn install will fail with

error openid-client@5.1.8: The engine "node" is incompatible with this module. Expected version "^12.19.0 || ^14.15.0 || ^16.13.0". Got "18.12.1"
error Found incompatible module

A workaround is to use "resolutions" to use the correct version. But it should not be necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js 18 Support
4 participants