fix(next-auth): redirecting to /undefined when signIn method throws an error
#11010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
@andresgutgon is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
andresgutgon
commented
May 25, 2024
|
thanks @andresgutgon , could you help to add a test for this so that we don't regress? the change LGTM otherwise. |
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
|
What did I do to get mad at the bot? 😂 . Also why tests are not running? |
andresgutgon
force-pushed
the
fix/redirect-to-undefined-using-next-auth-with-server-actions
branch
from
fb1b9f9 to
d74e166
Compare
github-actions
bot
added
adapters
andresgutgon
commented
May 26, 2024
andresgutgon
force-pushed
the
fix/redirect-to-undefined-using-next-auth-with-server-actions
branch
from
d74e166 to
f9b1a41
Compare
andresgutgon
commented
May 26, 2024
andresgutgon
force-pushed
the
fix/redirect-to-undefined-using-next-auth-with-server-actions
branch
from
f9b1a41 to
744ad4f
Compare
andresgutgon
force-pushed
the
fix/redirect-to-undefined-using-next-auth-with-server-actions
branch
from
744ad4f to
cef0f19
Compare
error
@auth/core `Auth` function can return an internalResponse or a Standard
Response. Internal response has a `redirect` attribute. The problem is
that the logic inside `Auth` method when there is an error is returning
a Standard web Response which doesn't have `redirect` attribute but we
can get redirecting url by using `headers.get('Origin')`.
I think this fix this issue:
nextauthjs#11008
andresgutgon
force-pushed
the
fix/redirect-to-undefined-using-next-auth-with-server-actions
branch
from
cef0f19 to
5cebb45
Compare
|
@ThangHuuVu I think I did tests and docs. I can see docs in my machine working and the tests I did are passing too. Thanks for this software and glad to help! |
|
@ThangHuuVu I think I reviewed all the comments. Let me know anything I need to change |
andresgutgon
force-pushed
the
fix/redirect-to-undefined-using-next-auth-with-server-actions
branch
from
61abbe5 to
997aa02
Compare
andresgutgon
force-pushed
the
fix/redirect-to-undefined-using-next-auth-with-server-actions
branch
from
997aa02 to
0d804ea
Compare
andresgutgon
commented
May 27, 2024
| config | ||
| ) | ||
| expect(redirectTo).toEqual( | ||
| "http://localhost/api/auth/signin/nodemailer?" |
There was a problem hiding this comment.
@ThangHuuVu I made a test for that case. Is this what you meant?
…th-server-actions
ndom91
changed the title
/undefined when signIn method throws an error
|
@ThangHuuVu please let me know if there's anything else I can do to move forward with these changes? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11010 +/- ##
==========================================
+ Coverage 38.74% 40.85% +2.11%
==========================================
Files 176 176
Lines 27887 27893 +6
Branches 1217 1242 +25
==========================================
+ Hits 10804 11397 +593
+ Misses 17083 16496 -587 ☔ View full report in Codecov by Sentry. |
…th-server-actions
|
thanks @andresgutgon , sorry I was absent for the week. I pushed a commit to simplify the tests. |
ThangHuuVu
approved these changes
Jun 1, 2024
andresgutgon
deleted the
fix/redirect-to-undefined-using-next-auth-with-server-actions
branch
hillac
pushed a commit
to hillac/next-auth
that referenced
this pull request
Jun 19, 2024
…rows an error (nextauthjs#11010) * Fix NextAuth redirecting to /undefined when signIn method throws an error @auth/core `Auth` function can return an internalResponse or a Standard Response. Internal response has a `redirect` attribute. The problem is that the logic inside `Auth` method when there is an error is returning a Standard web Response which doesn't have `redirect` attribute but we can get redirecting url by using `headers.get('Origin')`. I think this fix this issue: nextauthjs#11008 * Move action test to tests folder * Remove test-adapter and add reference to docs * Defend from undefined responseUrl * Fix linter * chore(test): simplify tests --------- Co-authored-by: Thang Vu <hi@thvu.dev>
k3k8
pushed a commit
to k3k8/next-auth
that referenced
this pull request
Aug 1, 2024
…rows an error (nextauthjs#11010) * Fix NextAuth redirecting to /undefined when signIn method throws an error @auth/core `Auth` function can return an internalResponse or a Standard Response. Internal response has a `redirect` attribute. The problem is that the logic inside `Auth` method when there is an error is returning a Standard web Response which doesn't have `redirect` attribute but we can get redirecting url by using `headers.get('Origin')`. I think this fix this issue: nextauthjs#11008 * Move action test to tests folder * Remove test-adapter and add reference to docs * Defend from undefined responseUrl * Fix linter * chore(test): simplify tests --------- Co-authored-by: Thang Vu <hi@thvu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
When using a custom signin page in a NextJS app and using a server action as explained in the docs:
https://authjs.dev/guides/pages/signin
When the auth fails. For example
error=ConfigurationErrorit doesn't redirect to error page. It redirects to/undefinedThe problem
I think that
@auth/coreAuthfunction can return anInternalResponseor a standard webResponse. Internal response has aredirectattribute. The problem is that the logic insideAuthmethod when there is an error returns a Standard web Response that doesn't haveredirectattribute but we can get a redirecting url by usingheaders.get('Location').What changes are being made? What feature/bug is being fixed here?
We check if the returned response is a next auth
InternalResponseor a standard webResponse. This way we always get redirecting URL.🧢 Checklist
🎫 Affected issues
Fixes: #11008