-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(provider): Microsoft Entra ID #12616
Open
benhovinga
wants to merge
7
commits into
nextauthjs:main
Choose a base branch
from
benhovinga:microsoft-entra-id
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@benhovinga is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Clarified the usage of issuer parameter
7005e71
to
27486d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This PR resolves several issues with the Microsoft Entra ID provider.
Fix Documentation
Inconsistencies between the use of
issuer
andtenantId
. This implementation of the provider doesn't directly usetenantId
however it is used within part of theissuer
URI string. This PR clarifies how to use theissuer
parameter in both the Provider Docs and API Reference.Also fixed some inconsistencies between frameworks
Fix
MicrosoftEntraIDProfile
interfaceThe
MicrosoftEntraIDProfile
interface was missing a lot of the claims returned from the provider server. This PR adds allid_token
claims.Fix default issuer
If the environment variable
AUTH_MICROSOFT_ENTRA_ID_ISSUER
is configured but theissuer
parameter is not set, the default issuer overwrites the environment variable. This PR checks if the environment variable is configured first before falling back to the default issuer.Now the provider "can" be used without any configuration, like this.
Finish Provider Implementation
Add the provider to the OAuth providers search and the Issues Template providers dropdown.
🧢 Checklist
🎫 Affected issues
Fixes: #12314, #12193, #12195
Corrects: #12612
📌 Resources