feat(core): Use AdapterSession retruned from updateSession function #12864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@codylittle is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
adapters
Author
|
Hey @ThangHuuVu, anything else you'd like to see in the PR prior to reviewing? Happy to add additional tests if required. |
Author
|
@ThangHuuVu does this align with the direction of the package? Should this be moved to a flag to ensure backwards compatibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Currently the
updateSessionfunction within Adapters has the option to return anAdapterSession, yet this session is just discarded. The ability to use this returned session allows for further customisation of business-specific logic within custom adapters without impacting existing available adapters.🧢 Checklist
Note: I have updated session tests, how I am unable to run them as-is due to incorrect relative file paths. Updating the file paths by hand results in passing tests, but I have not committed these updates as I believe I like have local configuration incorrect.
Happy to discuss further if required.