Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter): upgrade legacy adapters #1952

Merged
merged 13 commits into from
May 10, 2021
Merged

fix(adapter): upgrade legacy adapters #1952

merged 13 commits into from
May 10, 2021

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented May 7, 2021

This brings all the work done in #1871 to the built-in adapters

  • TypeORM
  • Prisma

Reasoning 💡

We are moving the adapters out of the main repo, and in the process, we are making creating new adapters easier by taking away the error handling responsibility and move it to the core. This drastically simplifies custom adapter code complexity

Checklist 🧢

Affected issues 🎟

#1832

@vercel
Copy link

vercel bot commented May 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nextauthjs/next-auth/97V6G85LuSdiXuCGQV5Vh324hxs2
✅ Preview: https://next-auth-git-feat-update-typeorm-nextauthjs.vercel.app

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` labels May 7, 2021
@balazsorban44 balazsorban44 marked this pull request as draft May 7, 2021 15:52
@vercel vercel bot temporarily deployed to Preview May 10, 2021 20:52 Inactive
@github-actions github-actions bot added the TypeScript Issues relating to TypeScript label May 10, 2021
@vercel vercel bot temporarily deployed to Preview May 10, 2021 20:54 Inactive
@vercel vercel bot temporarily deployed to Preview May 10, 2021 20:55 Inactive
@balazsorban44 balazsorban44 marked this pull request as ready for review May 10, 2021 20:56
@balazsorban44 balazsorban44 requested a review from ubbe-xyz as a code owner May 10, 2021 20:56
@vercel vercel bot temporarily deployed to Preview May 10, 2021 20:56 Inactive
@balazsorban44 balazsorban44 changed the title fix(adapter): upgrade typeorm-legacy-adapter fix(adapter): upgrade legacy adapters May 10, 2021
@vercel vercel bot temporarily deployed to Preview May 10, 2021 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview May 10, 2021 21:43 Inactive
@vercel vercel bot temporarily deployed to Preview May 10, 2021 21:47 Inactive
@vercel vercel bot temporarily deployed to Preview May 10, 2021 21:50 Inactive
@vercel vercel bot temporarily deployed to Preview May 10, 2021 21:56 Inactive
@balazsorban44 balazsorban44 force-pushed the feat/update-typeorm branch from 3105f0c to b212255 Compare May 10, 2021 22:03
@vercel vercel bot temporarily deployed to Preview May 10, 2021 22:10 Inactive
@balazsorban44 balazsorban44 merged commit c0d2f2d into main May 10, 2021
@balazsorban44 balazsorban44 deleted the feat/update-typeorm branch May 10, 2021 22:15
mnphpexpert added a commit to mnphpexpert/next-auth that referenced this pull request Sep 2, 2024
* refactor(adapter): upgrade typeorm-legacy-adapter

* fix(ts): correct exported typeorm types

* fix(adapter): correct adapter exports

* chore(deps): upgrade typeorm-legacy-adapter

* chore(deps): upgrade dependencies

* chore: match comment for legacy adapters

* fix(ts): correctly export Prisma legacy types

* chore(deps): upgrade prisma legacy adapter

* chore(deps): remove unused dependencies

* test(ts): only run TS tests on latest TS version

* chore(deps): remove unused dev dependencies

* chore(deps): upgrade prisma adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters core Refers to `@auth/core` TypeScript Issues relating to TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant