-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(adapter): upgrade legacy adapters #1952
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nextauthjs/next-auth/97V6G85LuSdiXuCGQV5Vh324hxs2 |
github-actions
bot
added
adapters
Changes related to the core code concerning database adapters
core
Refers to `@auth/core`
labels
May 7, 2021
This was referenced May 7, 2021
balazsorban44
changed the title
fix(adapter): upgrade typeorm-legacy-adapter
fix(adapter): upgrade legacy adapters
May 10, 2021
balazsorban44
force-pushed
the
feat/update-typeorm
branch
from
May 10, 2021 22:03
3105f0c
to
b212255
Compare
mnphpexpert
added a commit
to mnphpexpert/next-auth
that referenced
this pull request
Sep 2, 2024
* refactor(adapter): upgrade typeorm-legacy-adapter * fix(ts): correct exported typeorm types * fix(adapter): correct adapter exports * chore(deps): upgrade typeorm-legacy-adapter * chore(deps): upgrade dependencies * chore: match comment for legacy adapters * fix(ts): correctly export Prisma legacy types * chore(deps): upgrade prisma legacy adapter * chore(deps): remove unused dependencies * test(ts): only run TS tests on latest TS version * chore(deps): remove unused dev dependencies * chore(deps): upgrade prisma adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
adapters
Changes related to the core code concerning database adapters
core
Refers to `@auth/core`
TypeScript
Issues relating to TypeScript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings all the work done in #1871 to the built-in adapters
Reasoning 💡
We are moving the adapters out of the main repo, and in the process, we are making creating new adapters easier by taking away the error handling responsibility and move it to the core. This drastically simplifies custom adapter code complexity
Checklist 🧢
package-lock.json
will need an upgrade on this PR.package-lock.json
will need an upgrade on this PR.- [ ] Documentationdtslint
fails on GitHub Actions)Affected issues 🎟
#1832