Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies #26

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Remove unused dependencies #26

merged 1 commit into from
Jul 20, 2021

Conversation

Pytal
Copy link
Contributor

@Pytal Pytal commented Jul 19, 2021

Addendum to #24

@Pytal
Remove unused dependencies
bdab8d8 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added the 3. to review Waiting for reviews label Jul 19, 2021
@Pytal Pytal self-assigned this Jul 19, 2021
@Pytal Pytal merged commit 8faf4f8 into master Jul 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/remove-unused-deps branch July 20, 2021 20:22
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 20, 2021
@skjnldsv
Copy link
Contributor

skjnldsv commented Jul 26, 2021 •
edited
Loading

@Pytal removing @babel/plugin-proposal-class-properties broke custom classes like https://github.com/nextcloud/viewer/blob/dbfa6bc8ead717530001a981b7d442510bf8d897/src/services/Viewer.js#L29-L30

@skjnldsv
Copy link
Contributor

image

@Pytal Pytal mentioned this pull request Jul 27, 2021
Closed
@Pytal
Copy link
Contributor Author

Pytal commented Jul 27, 2021

@Pytal removing @babel/plugin-proposal-class-properties broke custom classes like https://github.com/nextcloud/viewer/blob/dbfa6bc8ead717530001a981b7d442510bf8d897/src/services/Viewer.js#L29-L30

Fixed in #30 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @skjnldsv @juliushaertl