Closed
Conversation
2 tasks
Contributor
Author
|
@susnux would be nice to have the vue props being exported in the docs. |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
susnux
reviewed
May 2, 2025
Contributor
There was a problem hiding this comment.
Please not another API package with UI components.
- It increases bundle size a lot even if you do not use Vue for your app
- It bounds an API only library to UI
- More complex dependencies
- This creates a circular dependency between nextcloud-vue and nextcloud-auth
Instead this probably should belong just to @nextcloud/vue for UI components or if you consider it a dialog maybe also to @nextcloud/dialogs but makes no sense to make another simple logic library a UI package.
Contributor
Author
|
Ah, sure thing!! Wasn't aware this was such a bad pattern 👍 |
Contributor
Author
|
Smaller extract without UI: #795 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This component is aimed to standardise this a bit more.
As I'm currently adding a bit more visibility towards how you're seen as a guest on an instance, I thought it would be nice to create this.

Features:
getGuestUsermethod that looks similar to a normal usershowGuestUserPromptthat spawns a dialogScreenshots
Folder share
Talk room
Code snippet example