Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Apr 25, 2025

  • Adjust dependencies for Vue 3
  • Adjusted documentation: This package is now also compatible with Vue 3 and Vue 2 (while when using Vue 3 in app the bundle size is smaller)
  • Adjusted code to Vue 3
    • Due to already using <script setup> we do not need to touch the components a lot, only drop second <script> as the name is now automatically inferred by the filename with Vue 3 and script setup.
    • props vs propsData
    • v-model:prop vs :prop.sync
    • 💥 drop deprecated Dialog.hide which allows us to use spawnDialog from @nextcloud/vue also for Vue 3
    • 💥 drop filepicker component export to make the package Vue version agnostic

I also tested this with server and it seems to work fine.

@susnux susnux force-pushed the feat/vue3 branch 2 times, most recently from 4588d4c to ca1fd31 Compare April 29, 2025 15:56
susnux added 5 commits April 29, 2025 17:58
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added the enhancement New feature or request label Apr 29, 2025
@ShGKme ShGKme removed their request for review April 29, 2025 16:09
@susnux susnux merged commit aa5ccb4 into main May 2, 2025
11 checks passed
@susnux susnux deleted the feat/vue3 branch May 2, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Vue 3.x

3 participants