Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filename): Improve filename validation to support Nextcloud 30 capabilities #1013

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 11, 2024

With Nextcloud 30 there are more options to restrict filenames, so we need to adjust our filename validation.
This now also provides validateFilename which will throw an error if invalid, to allow better user feedback on what is wrong.

…apabilities

With Nextcloud 30 there are more options to restrict filenames,
so we need to adjust our filename validation.
This now also provides `validateFilename` which will throw an error if invalid,
to allow better user feedback on what is wrong.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added enhancement New feature or request 3. to review labels Jul 11, 2024
@susnux susnux requested review from artonge, skjnldsv and Pytal July 11, 2024 17:36
Copy link

codecov bot commented Jul 11, 2024

Bundle Report

Changes will increase total bundle size by 4.54kB ⬆️

Bundle name Size Change
@nextcloud/files-esm 97.52kB 2.22kB ⬆️
@nextcloud/files-esm-cjs 98.76kB 2.33kB ⬆️

@skjnldsv skjnldsv merged commit 0f6b74f into main Jul 12, 2024
17 checks passed
@skjnldsv skjnldsv deleted the fix/adjust-filename-validation branch July 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants