fix: Make types of File and Folder more explicit #1118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both inherit from Node which is generic, thus e.g. the
mime
field is of typestring
. But for folders the mime can never be something different to'httpd/unix-directory'
.So the correct type would be the string literal
'httpd/unix-directory'
.The same for the
type
attribute forFile
andFolder
.⬆️ While this could be seen as an improvement it actually fixes a Typescript issue:
This I expect to work, but it fails with: