fix: Typo in method name isDavResource instead of isDavRessource
#1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depreacte the old variant and make it an alias of the correct name, so we can remove it in the next major version. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Bundle ReportChanges will increase total bundle size by 296 bytes (0.06%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
==========================================
- Coverage 91.77% 91.62% -0.15%
==========================================
Files 23 23
Lines 632 633 +1
Branches 166 166
==========================================
Hits 580 580
- Misses 45 46 +1
Partials 7 7 ☔ View full report in Codecov by Sentry. |
skjnldsv
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
I can't believe it.... 🤦🤦🤦🤦
What a false french friend 🫠
https://www.larousse.fr/dictionnaires/francais/ressource/68738
Yes, same for German: https://www.duden.de/rechtschreibung/Ressource |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depreacte the old variant and make it an alias of the correct name, so we can remove it in the next major version.