Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup package and make it a native ESM package #704

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 25, 2023

  • Drop unneeded .npmignore (files section of package.json overrides it anyways)
  • Make package an ESM one (migrate config files to modules)
    • ESLint currently does not support an esm config, so use the json config instead
  • Use bundler as Typescript resolution as we use rollup anyways
  • Update package lock file to version 3 as we use NPM 9 already
    • Update versions inside package.json to match the package-lock updated ones

@susnux susnux added the 3. to review 3️⃣ Waiting for reviews label Jul 25, 2023
@susnux susnux requested a review from skjnldsv July 25, 2023 10:56
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3dcb3ad) 100.00% compared to head (660eb89) 100.00%.

❗ Current head 660eb89 differs from pull request most recent head 3999b9b. Consider uploading reports for the commit 3999b9b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #704   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          236       236           
  Branches        69        69           
=========================================
  Hits           236       236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@susnux susnux force-pushed the chore/cleanup-package branch from 660eb89 to 498e618 Compare July 25, 2023 16:29
* Drop unneeded .npmignore (`files` section of package.json overrides it anyways)
* Make package an ESM one (migrate config files to modules)
  * ESLint currently does not support an esm config, so use the json config instead
* Use `bundler` as Typescript resolution as we use rollup anyways

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv skjnldsv merged commit 3999b9b into master Jul 26, 2023
@skjnldsv skjnldsv deleted the chore/cleanup-package branch July 26, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review 3️⃣ Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants