Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): remove auto mtime update on attributes change and allow mtime set #974

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix(node): remove auto mtime update on attributes change and allow mtime set #974

merged 2 commits into from
Jun 4, 2024

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jun 4, 2024 •
edited
Loading

@skjnldsv
fix(node): remove auto mtime update on attributes change and allow mt…
329b177 
…ime set

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the 3. to review 3️⃣ Waiting for reviews label Jun 4, 2024
@skjnldsv skjnldsv requested a review from susnux June 4, 2024 13:00
@skjnldsv skjnldsv self-assigned this Jun 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 134 bytes ⬇️

Bundle name Size Change
@nextcloud/files-esm 109.76kB 67 bytes ⬇️
@nextcloud/files-esm-cjs 110.79kB 67 bytes ⬇️

@skjnldsv skjnldsv mentioned this pull request Jun 4, 2024
Closed
susnux
susnux approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!
Do you think we should make updateMTime public for convenience?

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Jun 4, 2024 •
edited
Loading

Makes sense! Do you think we should make updateMTime public for convenience?

doesn't hurt, but not sure it's really necessary 🤔
EDIT: done

@skjnldsv
feat(node): make updateMtime available
249ff84 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit dc74837 into main Jun 4, 2024
13 checks passed
@skjnldsv skjnldsv deleted the fix/mtime-auto branch June 4, 2024 13:15
@skjnldsv skjnldsv mentioned this pull request Jul 2, 2024
Merged
@JhayceFrancis JhayceFrancis mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review 3️⃣ Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @susnux