feat(navigation): Allow to listen for active navigation changes #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
feat/allow-listening-active-view
branch
from
98e7d76
to
808ab7c
Compare
Bundle ReportChanges will increase total bundle size by 1.63kB ⬆️
|
Nice! |
In general it is now the same as with native JS / HTML element you can add / remove event listeners.
I can add an example, yes :) |
susnux
force-pushed
the
feat/allow-listening-active-view
branch
from
808ab7c
to
6b2dbbf
Compare
|
Examples added |
This adds the native `EventTarget` class to the Navigation allowing to add listeners to it. Allowing to dispatch the `updateActive` event when the active navigation changed. The idea is to make it reactive in a native / framework agnostic way. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/allow-listening-active-view
branch
from
6b2dbbf
to
c046d93
Compare
ShGKme
approved these changes
Jun 14, 2024
|
Breaks stable28 & stable29 reactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the native
EventTargetclass to the Navigation allowing to add listeners to it. Allowing to dispatch theupdateActiveevent when the active navigation changed.The idea is to make it reactive in a native / framework agnostic way.