fix: make davRootPath and davRemoteURL support public shares
#996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
commented
Jun 18, 2024
Bundle ReportChanges will increase total bundle size by 316 bytes ⬆️
|
susnux
force-pushed
the
feat/public-share-paths
branch
from
3545444
to
b13ee40
Compare
susnux
added
bug
susnux
changed the title
davRootPath and davRemoteURL support public sharesdavRootPath and davRemoteURL support public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/public-share-paths
branch
from
b13ee40
to
790b705
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
+ Coverage 84.31% 84.48% +0.17%
==========================================
Files 21 20 -1
Lines 529 535 +6
Branches 138 139 +1
==========================================
+ Hits 446 452 +6
Misses 69 69
Partials 14 14 ☔ View full report in Codecov by Sentry. |
st3iny
approved these changes
Jun 20, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last missing piece for public share support 🚀