Improve password confirmation dialog #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JuliaKirschenheuter
changed the title
@nextcloud/vue lib and improve password confirmation dialog
ShGKme
requested changes
Oct 5, 2023
|
Looks a little bit different than in the linked comment, but seems to be fine in terms of a11y
|
|
Upgrade to |
what look s different? |
Label position
|
Recording.2023-09-27.182535.mp4 |
JuliaKirschenheuter
force-pushed
the
fix/37080-update_nextcloud-vue_and_password_dialog
branch
from
101de3e
to
5bc2765
Compare
|
Is this problem in the comment from the linked issue also supposed to be fixed? Should we do something with this message with failed authentication? |
|
P.S. Don't forget to run npm run l10n:extract |
Pytal
approved these changes
Oct 6, 2023
susnux
approved these changes
Oct 6, 2023
|
@nickvergessen could i leave an error message like this ? There is only one input field with password confirmation so i think it is ok to have more specific message. Please see nextcloud/server#37080 (comment) |
|
What about using
Like on the Login page:
Then it would be:
|
ShGKme
reviewed
Oct 9, 2023
ShGKme
reviewed
Oct 9, 2023
JuliaKirschenheuter
force-pushed
the
fix/37080-update_nextcloud-vue_and_password_dialog
branch
2 times, most recently
from
467bdeb
to
1c6fca7
Compare
ShGKme
approved these changes
Oct 9, 2023
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/37080-update_nextcloud-vue_and_password_dialog
branch
from
606d7e7
to
b8b339c
Compare
ShGKme
approved these changes
Oct 9, 2023
artonge
approved these changes
Oct 9, 2023
JuliaKirschenheuter
deleted the
fix/37080-update_nextcloud-vue_and_password_dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by https://github.com/nextcloud-libraries/nextcloud-password-confirmation/compare/update-nc-vue-to-v.8?expand=1
Fixes nextcloud/server#40643 (comment)
Fixes nextcloud/server#37080 (comment)