-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add method to get a base URL, allow to pass remote base #558
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New option is defined for
generateUrl
generateOcsUrl
But implementation only covers:
generateOcsUrl
This method doesn't have a base part, so I assume, it's not applicable here? Lines 101 to 111 in e3c586b
|
But you need to overwrite What about |
These methods are not affected by current changes. UPD: Covered now, I beleive |
e3c586b
to
0585141
Compare
Do you have any other ideas for this variable name? |
federation? |
Or proxy something as a reverse proxy is a pretty standard concept. |
I'd call it as it actually should be called, |
|
Tested, won't be a problem, unless you pass a relative URL to axios request |
0585141
to
9640d02
Compare
9640d02
to
3457dcc
Compare
@Antreesy looks good to me, could you rebase and maybe add tests for the changed behavior? |
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
3457dcc
to
9826c00
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #558 +/- ##
==========================================
+ Coverage 97.28% 97.54% +0.25%
==========================================
Files 1 1
Lines 221 244 +23
Branches 33 36 +3
==========================================
+ Hits 215 238 +23
Misses 5 5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
…tance by default) Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
9826c00
to
bec5dd4
Compare
PR is adding:
getBaseUrl
method to get the current instance;I'd say, there are most prominent use-cases which I see:
Tests: