Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ShareType enum to replace Type with more JS native naming #22

Merged
merged 1 commit into from
Jun 19, 2024
Merged

feat: Add ShareType enum to replace Type with more JS native naming #22

merged 1 commit into from
Jun 19, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 19, 2024 •
edited
Loading

This also prevents name clashes with other Type classes or enums

@susnux susnux added 3. to review Waiting for reviews enhancement New feature or request labels Jun 19, 2024
@susnux susnux requested a review from st3iny June 19, 2024 10:01
@susnux
feat: Add ShareType enum to replace Type with more JS native naming
3892f2e 
This also prevents name clashes with other `Type` classes or enums

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Base automatically changed from refactor to main June 19, 2024 10:27
@susnux susnux merged commit a7db9e4 into main Jun 19, 2024
9 checks passed
@susnux susnux deleted the ref/share-type branch June 19, 2024 10:27
@susnux susnux mentioned this pull request Jun 19, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @st3iny