Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appConfig): move chunks to chunks sub directory #294

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 12, 2024

Maybe it's very personal preferences, but I always find it easer to debug build output when outDirs contains only entries first (files you will need to manually include in apps' templates) and chunks separated.

Especially in apps with many entries and tons of chunks

Before After
image image

ShGKme added 3 commits August 13, 2024 00:21
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 2. developing Feature still under development labels Aug 12, 2024
@ShGKme ShGKme requested a review from susnux August 12, 2024 22:28
@ShGKme ShGKme self-assigned this Aug 12, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 30, 2024

@susnux What do you thinks? If you fine with it, I'll finish PR, polish and fix tests.

@susnux
Copy link
Contributor

susnux commented Aug 30, 2024

Would be fine with me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Feature still under development bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants