Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Support vite v5 #87

Merged
merged 1 commit into from
Dec 19, 2023
Merged

enh: Support vite v5 #87

merged 1 commit into from
Dec 19, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 19, 2023

This is a minimal version of #85 without bundling

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added enhancement New feature or request 3. to review Ready to review labels Dec 19, 2023
@susnux susnux requested review from skjnldsv and ShGKme December 19, 2023 11:52
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (39baceb) 81.62% compared to head (0904cfa) 81.09%.

Files Patch % Lines
lib/index.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   81.62%   81.09%   -0.53%     
==========================================
  Files           8        8              
  Lines         577      582       +5     
  Branches       48       48              
==========================================
+ Hits          471      472       +1     
- Misses         58       62       +4     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

Tested with @nextcloud/vue and server on Vite 4 and Vite 5.

@skjnldsv skjnldsv merged commit 5505541 into main Dec 19, 2023
9 of 11 checks passed
@skjnldsv skjnldsv deleted the try-v5 branch December 19, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants