Skip to content

Commit

Permalink
Fix user bubble when username contains a space
Browse files Browse the repository at this point in the history
Signed-off-by: Louis Chemineau <louis@chmn.me>
  • Loading branch information
artonge committed May 11, 2021
1 parent 40892bb commit 407f7bd
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
13 changes: 13 additions & 0 deletions src/components/RichContenteditable/RichContenteditable.vue
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,19 @@ export default {
status: 'away',
},
subline: 'Visiting London',
},
'Test 03': {
icon: 'icon-user',
id: 'Test 03',
label: 'Test 03',
source: 'users',
status: {
clearAt: null,
icon: '🎡',
message: 'Having space in my name',
status: 'in space',
},
subline: 'Visiting London',
}
}
}
Expand Down
5 changes: 2 additions & 3 deletions src/mixins/richEditor/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const MENTION_START = '(?:^|\\s)'
// Anything that is not text or end-of-line. Non-capturing group
const MENTION_END = '(?:[^a-z]|$)'
export const USERID_REGEX = new RegExp(`${MENTION_START}(@[a-zA-Z0-9_.@\\-']+)(${MENTION_END})`, 'gi')
export const USERID_REGEX_WITH_SPACE = new RegExp(`${MENTION_START}(@"[a-zA-Z0-9 _.@\\-']+")(${MENTION_END})`, 'gi')
export const USERID_REGEX_WITH_SPACE = new RegExp(`${MENTION_START}(@&quot;[a-zA-Z0-9 _.@\\-']+&quot;)(${MENTION_END})`, 'gi')

export default {
props: {
Expand Down Expand Up @@ -74,8 +74,7 @@ export default {
}

// Extracting the id, nuking the " and @
const id = part.replace(/[@"]/gi, '')

const id = part.replace(/@|&quot;/gi, '')
// Compiling template and prepend with the space we removed during the split
return ' ' + this.genSelectTemplate(id)
})
Expand Down

0 comments on commit 407f7bd

Please sign in to comment.