Skip to content

Commit

Permalink
Fix EmptyContent Reactivity
Browse files Browse the repository at this point in the history
Signed-off-by: Jonas Rittershofer <jotoeri@users.noreply.github.com>
  • Loading branch information
jotoeri committed Aug 23, 2022
1 parent 7b09608 commit 9442870
Showing 1 changed file with 9 additions and 21 deletions.
30 changes: 9 additions & 21 deletions src/components/NcEmptyContent/NcEmptyContent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,14 @@ export default {

<template>
<div class="empty-content" role="note">
<div v-if="hasIcon" class="empty-content__icon">
<div v-if="$slots.icon" class="empty-content__icon">
<!-- @slot Optional material design icon -->
<slot name="icon" />
</div>
<h2 v-if="hasTitle" class="empty-content__title">
<!-- @slot Optional title -->
<slot />
{{ title }}
</h2>
<p v-if="hasDescription">
<p v-if="$slots.desc">
<!-- @slot Optional description -->
<slot name="desc" />
</p>
Expand All @@ -92,27 +91,16 @@ export default {
export default {
name: 'NcEmptyContent',

data() {
return {
/**
* Making sure the slots are reactive
*/
slots: this.$slots,
}
props: {
title: {
type: String,
default: '',
},
},

computed: {
hasIcon() {
return this.slots.icon !== undefined
},

hasTitle() {
return this.slots?.default !== undefined
&& this.slots?.default[0]?.text
},

hasDescription() {
return this.slots?.desc !== undefined
return this.title !== ''
},
},
}
Expand Down

0 comments on commit 9442870

Please sign in to comment.