Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable modal primary button styling #275

Closed
juliusknorr opened this issue Feb 25, 2019 · 8 comments
Closed

Allow to disable modal primary button styling #275

juliusknorr opened this issue Feb 25, 2019 · 8 comments
Labels
1. to develop Accepted and waiting to be taken care of design Design, UX, interface and interaction design enhancement New feature or request feature: modal Related to the modal component
Milestone
0.9.6

Comments

@juliusknorr
Copy link
Contributor

In the viewer the next button should just be a regular one instead of one with primary color.
@juliusknorr juliusknorr added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of feature: modal Related to the modal component labels Feb 25, 2019
@skjnldsv
Copy link
Contributor

@juliushaertl any particular reason? I kinda like the dual tone on this one :)
@jancborchardt shall we go for the same button design as default?

@juliusknorr
Copy link
Contributor Author

@juliushaertl any particular reason? I kinda like the dual tone on this one :)

No real reason, it just looked a bit odd to me when testing ;)

@skjnldsv
Copy link
Contributor

Should we set the primary style on hover/focus? :)

@skjnldsv skjnldsv added the design Design, UX, interface and interaction design label Feb 25, 2019
@skjnldsv skjnldsv mentioned this issue Feb 26, 2019
Merged
@skjnldsv
Copy link
Contributor

skjnldsv commented Mar 6, 2019

🛎️
@ChristophWurst any opinions? :)

@skjnldsv skjnldsv added discussion Need advices, opinions or ideas on this topic and removed 1. to develop Accepted and waiting to be taken care of labels Mar 6, 2019
@ChristophWurst
Copy link
Contributor

Nope 🤷‍♂️

@jancborchardt
Copy link
Contributor

The primary button styling should only be there in the first run wizard, so an optional styling.

For the picture viewer, "Next" is not necessarily the more important action, and also it takes way too much attention away from the actual content. In picture viewers, all the actions are usually monochrome.

@skjnldsv
Copy link
Contributor

Let's do it! 💪

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed discussion Need advices, opinions or ideas on this topic labels Mar 12, 2019
@skjnldsv skjnldsv added this to the next milestone Mar 12, 2019
@jancborchardt jancborchardt mentioned this issue Mar 12, 2019
Closed
62 tasks
@skjnldsv skjnldsv closed this as completed Apr 3, 2019
@skjnldsv
Copy link
Contributor

skjnldsv commented Apr 3, 2019

Closed as this is disabled by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of design Design, UX, interface and interaction design enhancement New feature or request feature: modal Related to the modal component
Projects
None yet
Milestone
0.9.6
Development

No branches or pull requests
4 participants
@jancborchardt @ChristophWurst @juliusknorr @skjnldsv