Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal title and actions #277

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Modal title and actions #277

merged 1 commit into from
Feb 26, 2019

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Feb 26, 2019 •
edited
Loading

  • Add modal slideshow
  • Add modal title
  • Add modal actions
  • Hide ui when the mouse is still

peek 26-02-2019 12-27

capture d ecran_2019-02-26_12-31-51

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews high High priority feature: modal Related to the modal component labels Feb 26, 2019
@skjnldsv skjnldsv added this to the next milestone Feb 26, 2019
@skjnldsv skjnldsv self-assigned this Feb 26, 2019
@skjnldsv skjnldsv force-pushed the modal-title-and-actions branch from fdb9b8a to c0cec50 Compare February 26, 2019 11:48
@juliusknorr
Copy link
Contributor

@skjnldsv Nice. However now we have two primary buttons, which seems a bit confusing as there shown't be two actions highlighted that way. I think next is definitely the main action here, while the slideshow start/stop is just an action.

@skjnldsv
Copy link
Contributor Author

@skjnldsv Nice. However now we have two primary buttons, which seems a bit confusing as there shown't be two actions highlighted that way. I think next is definitely the main action here, while the slideshow start/stop is just an action.

So, about #275, do you rather go with no primary at all? Or just the next? :)
I'm fine with both!

@skjnldsv
Copy link
Contributor Author

@juliushaertl how about this?
capture d ecran_2019-02-26_14-56-58

@skjnldsv
Copy link
Contributor Author

@juliushaertl done!
dev skjnldsv com_apps_vueexample_

@skjnldsv skjnldsv requested a review from juliusknorr February 26, 2019 14:55
@skjnldsv skjnldsv force-pushed the modal-title-and-actions branch from 8f82b8d to db72b62 Compare February 26, 2019 15:05
@skjnldsv skjnldsv force-pushed the modal-title-and-actions branch from db72b62 to 95a28f3 Compare February 26, 2019 15:15
@skjnldsv
Add modal clear view with timeout, title, actions and slideshow with
0b49d2e 
customisable delay

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the modal-title-and-actions branch from 95a28f3 to 0b49d2e Compare February 26, 2019 15:19
@juliusknorr juliusknorr merged commit 708ecea into master Feb 26, 2019
@juliusknorr juliusknorr deleted the modal-title-and-actions branch February 26, 2019 15:32
@skjnldsv skjnldsv modified the milestones: next, 0.7.1 Mar 2, 2019
@jancborchardt
Copy link
Contributor

Hehe, looking at backlog issue, my main feedback would have been what @juliushaertl already said about there being 2 primary buttons. :) Good stuff! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request feature: modal Related to the modal component high High priority
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @juliusknorr @jancborchardt