Fix sidebar title height with subtitle #1150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
|
Hum, it doesn't seems to be an issue anywhere else, why only on deck? |
|
Because deck is the only one which uses a subtitle? |
|
Actually it was a deck issue with an old global css rule that caused this, see fix in nextcloud/deck#2019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open the sidebar of a deck card:
not sure why the height was there in first place. But the padding from
https://github.com/nextcloud/nextcloud-vue/blob/545b8ecb645d13cfafe1e25a2ad5f2c57fd4afe2/src/components/AppSidebar/AppSidebar.vue#L569
Seems to cause the problems with a fixed height.
So either we add more magic, or we don't use a fixed height anymore