Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppNavigationItem improved editing mode and AppNavigationNewItem component #1277

Merged
merged 45 commits into from
Nov 23, 2020
Merged

AppNavigationItem improved editing mode and AppNavigationNewItem component #1277

merged 45 commits into from
Nov 23, 2020

Commits on Sep 26, 2020

  1. Update AppNavigationItem.vue 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    19cfc93 View commit details
    Browse the repository at this point in the history

  2. changed name to newItem 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    3d4f217 View commit details
    Browse the repository at this point in the history

  3. fixed missing comma and linting errors 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    86de79e View commit details
    Browse the repository at this point in the history

  4. implemented newItem behaviour 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    7c6c6fd View commit details
    Browse the repository at this point in the history

  5. renamed variables and classes 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    23decec View commit details
    Browse the repository at this point in the history

  6. started updating the documentation 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    f7d6d07 View commit details
    Browse the repository at this point in the history

  7. added a icon to the new item example in the documentation 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    09ef60e View commit details
    Browse the repository at this point in the history

  8. improved comment 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    3990691 View commit details
    Browse the repository at this point in the history

  9. moved newItem Code into own block, to not have an a element that mess… 

    …es up the events

Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    1227569 View commit details
    Browse the repository at this point in the history

  10. fixed style issues 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    02409f1 View commit details
    Browse the repository at this point in the history

  11. fixed linting errors 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    5d7a37b View commit details
    Browse the repository at this point in the history

  12. fixed a few errors 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    ffcadbf View commit details
    Browse the repository at this point in the history

  13. changed documentation event alert text 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    b2dc51b View commit details
    Browse the repository at this point in the history

  14. added icon to the editing mode 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    e1e90e0 View commit details
    Browse the repository at this point in the history

  15. changed pretty much everything 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    8f311ed View commit details
    Browse the repository at this point in the history

  16. improved design 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    5e7e395 View commit details
    Browse the repository at this point in the history

  17. seperated editing and newItem completely 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    14ef594 View commit details
    Browse the repository at this point in the history

  18. sorted methods 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    2891535 View commit details
    Browse the repository at this point in the history

  19. added a icon to the editable item example in the docs 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    05089e5 View commit details
    Browse the repository at this point in the history

  20. modified the alert messages of editable and new Item in the documenta… 

    …tion

Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    7d8f3e2 View commit details
    Browse the repository at this point in the history

  21. moved the input with confirm and cancel buttons into an own component 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    d70b838 View commit details
    Browse the repository at this point in the history

  22. cleaned up scss 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    c5d6715 View commit details
    Browse the repository at this point in the history

  23. updated the documentation 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    7f4f257 View commit details
    Browse the repository at this point in the history

  24. prevent editable item from getting selected when clicking on the text… 

    … input or confirm/cancel button

Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    027554a View commit details
    Browse the repository at this point in the history

  25. started moving newItem into a dedicated component 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    3215b06 View commit details
    Browse the repository at this point in the history

  26. fixed navElement (no longer a link) 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    df1deff View commit details
    Browse the repository at this point in the history

  27. no longer using nav-element for newItem 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    ab60a99 View commit details
    Browse the repository at this point in the history

  28. updated docs and cleaned up old comments 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    bccbf9c View commit details
    Browse the repository at this point in the history

  29. fixed icons in AppNavigationNewItem 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    48884bb View commit details
    Browse the repository at this point in the history

  30. improved AppNavigationNewItem style, so the text does not move when a… 

    …ctivated

Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    40ca549 View commit details
    Browse the repository at this point in the history

  31. updated docs 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    f797164 View commit details
    Browse the repository at this point in the history

  32. fixed app-navigation-new-item__title style being overwritten by app-n… 

    …avigation-entry__title

Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    285a595 View commit details
    Browse the repository at this point in the history

  33. cleaned up messy css from the seperation into two components 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a747bc4 View commit details
    Browse the repository at this point in the history

  34. fixed stylelint warnings 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a1c2870 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Update AppNavigationNewItem.vue 

    Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
    @JonathanTreffler
    JonathanTreffler committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    0ae014c View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. added the loading state to the docs of AppNavigationNewItem 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    ef5ede3 View commit details
    Browse the repository at this point in the history

  2. fixing loading mode visual bug in AppNavigationNewItem 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    4f38ffc View commit details
    Browse the repository at this point in the history

  3. can no longer click on a AppNavigationNewItem while loading 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    b05ce3c View commit details
    Browse the repository at this point in the history

  4. fixed linting errors 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    0ad6375 View commit details
    Browse the repository at this point in the history

  5. added documentation for InputConfirmCancel 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    8633c59 View commit details
    Browse the repository at this point in the history

  6. fixed the copyright headers 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    6ab92bf View commit details
    Browse the repository at this point in the history

  7. fixed linting errors 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    508645d View commit details
    Browse the repository at this point in the history

  8. started re-implementing the automatic focus of the editing and newIte… 

    …m input box

Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    3bd8def View commit details
    Browse the repository at this point in the history

  9. continued development of the automatic input focus 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    694d0ee View commit details
    Browse the repository at this point in the history

  10. re-implementing auto focus done 

    Signed-off-by: TessyPowder <tessy.powder@gmail.com>
    @JonathanTreffler
    JonathanTreffler committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    10fc1d9 View commit details
    Browse the repository at this point in the history