-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to choose boundariesElement for actions' popover #1351
Allow to choose boundariesElement for actions' popover #1351
Conversation
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
37cb6e0
to
1f61494
Compare
@ma12-co Does this fix #1345 ? :) |
It allows you do fix it yeah, by specifying the element yourself. |
Well, not really, since you can't set custom props for the actions component for secondary actions: Let me see if adding |
It does :) |
But it actually should be an object, not a string :/ |
I'm testing now with the dom element body and it seems to work. Seems to be that we were passing in the string "body" |
Signed-off-by: Marco Ambrosini marcoambrosini@pm.me