Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow spaces in the name of a AppSidebarTab #1431

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Allow spaces in the name of a AppSidebarTab #1431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/AppSidebar/AppSidebarTabs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@
import Vue from 'vue'

const IsValidString = function(value) {
return value && typeof value === 'string' && value.trim() !== ''
}

const IsValidStringWithoutSpaces = function(value) {
return value && typeof value === 'string' && value.trim() !== '' && value.indexOf(' ') === -1
}

Expand Down Expand Up @@ -227,8 +231,8 @@ export default {
const tab = tabNode.componentInstance
// Make sure all required props are provided and valid
if (IsValidString(tab?.name)
&& IsValidString(tab?.id)
&& IsValidString(tab?.icon)) {
&& IsValidStringWithoutSpaces(tab?.id)
&& IsValidStringWithoutSpaces(tab?.icon)) {
tabs.push(tab)
} else {
invalidTabs.push(tabNode)
Expand Down