Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RichEditor rendering of unknown mention, undefined checks and fix default value init #1504

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Fix RichEditor rendering of unknown mention, undefined checks and fix default value init #1504

merged 2 commits into from
Nov 5, 2020

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Oct 21, 2020 •
edited
Loading

  • Do not render an unknown mention
  • Fix default value if any and fix pasting with custom data

@skjnldsv
Do not render an unknown user
128955b 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Oct 21, 2020
@skjnldsv skjnldsv added 3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components labels Oct 21, 2020
@skjnldsv
Fix default value if any and fix pasting with custom data
62a4259 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the fix/rich-content/various branch from 0e4c710 to 62a4259 Compare October 21, 2020 14:37
@skjnldsv skjnldsv changed the title Fix/rich content/various Fix Rich Editor rendering of unknown mention Oct 21, 2020
@skjnldsv skjnldsv changed the title Fix Rich Editor rendering of unknown mention Fix Rich Editor rendering of unknown mention, undefined checks and fix default value init Oct 21, 2020
@skjnldsv skjnldsv changed the title Fix Rich Editor rendering of unknown mention, undefined checks and fix default value init Fix RichEditor rendering of unknown mention, undefined checks and fix default value init Oct 21, 2020
@PVince81
Copy link
Contributor

@skjnldsv test steps to verify ?

@skjnldsv
Copy link
Contributor Author

@skjnldsv test steps to verify ?

code is pretty straightforward :p
But you can try rendering a mention of a user that is not provided on the userData.
Also see initial value fix:

Before

Capture d’écran_2020-10-22_09-53-49

After

Capture d’écran_2020-10-22_09-52-23

ChristophWurst
ChristophWurst approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv
Copy link
Contributor Author

Bump!

@skjnldsv
Copy link
Contributor Author

skjnldsv commented Nov 5, 2020

cc @PVince81

PVince81
PVince81 approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit dcac5c9 into master Nov 5, 2020
@PVince81 PVince81 deleted the fix/rich-content/various branch November 5, 2020 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@PVince81 PVince81 PVince81 approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@GretaD GretaD Awaiting requested review from GretaD

@julien-nc julien-nc Awaiting requested review from julien-nc

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @PVince81 @ChristophWurst