Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default font and line size #1542

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Add default font and line size #1542

merged 1 commit into from
Nov 5, 2020

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 4, 2020

Signed-off-by: GretaD gretadoci@gmail.com

@GretaD GretaD self-assigned this Nov 4, 2020
@GretaD GretaD added 3. to review Waiting for reviews enhancement New feature or request labels Nov 4, 2020
marcoambrosini
marcoambrosini reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line height needs to increase too

@GretaD GretaD mentioned this pull request Nov 4, 2020
Merged
@GretaD
Copy link
Contributor Author

GretaD commented Nov 4, 2020

This line height needs to increase too

which one? or you mean in general?

@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 5, 2020

@ma12-co those are the same values as server.

marcoambrosini
marcoambrosini requested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nextcloud/nextcloud-vue/pull/1542/files#diff-6fd3d6cda3923d725efadccd864a5de837a5b612a66e46f87272951e619de207R146

There, now that the font size increased to 15, the font size is 1 px bigger than the line height --> not good :)

@GretaD GretaD force-pushed the add/deafult_font_size branch from 6af05b4 to 81e337b Compare November 5, 2020 10:28
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 5, 2020
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 5, 2020

/backport to stable2

@skjnldsv skjnldsv force-pushed the add/deafult_font_size branch 2 times, most recently from b71f27e to b26dd0e Compare November 5, 2020 11:46
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 5, 2020

Trying to fix the cypress issue...

@skjnldsv skjnldsv force-pushed the add/deafult_font_size branch 5 times, most recently from dca2af0 to 1f4e457 Compare November 5, 2020 14:58
@GretaD @skjnldsv
Add default font and line size
48dc0e0 
Signed-off-by: GretaD <gretadoci@gmail.com>
@skjnldsv skjnldsv force-pushed the add/deafult_font_size branch from 1f4e457 to 48dc0e0 Compare November 5, 2020 15:02
@skjnldsv
Copy link
Contributor

skjnldsv commented Nov 5, 2020

Yeeep, I'm an idiot! 🚀

@skjnldsv skjnldsv merged commit 9fb1e94 into master Nov 5, 2020
@skjnldsv skjnldsv deleted the add/deafult_font_size branch November 5, 2020 15:07
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@GretaD GretaD

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GretaD @skjnldsv @marcoambrosini