Fix labelledby in tab section #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aria-labelledby must contain the id of an element that contains the label and not a direct text. This fixes it by pointing back to the matching tab heading element. As an additional bonus, this will semantically link this "tabpanel" to the matching "tab". Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
requested review from
ChristophWurst,
juliushaertl and
marcoambrosini
juliushaertl
approved these changes
Nov 19, 2020
marcoambrosini
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aria-labelledby must contain the id of an element that contains the
label and not a direct text. This fixes it by pointing back to the
matching tab heading element.
As an additional bonus, this will semantically link this "tabpanel" to
the matching "tab".
Tested with Talk and a screen reader: the screen reader now says "Participants region" or "Settings region" when clicking inside the tab.