Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix actions dropdown focus timing #1761

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Fix actions dropdown focus timing #1761

merged 2 commits into from
Mar 16, 2021

Commits on Mar 12, 2021

  1. Fix actions dropdown focus timing 

    Because "@after-show" is still happening too early due to v-tooltip's
use of "requestAnimationFrame" we can't rely on its events to tell us
when the popover is actually visible.

This workaround introduces an additional Popover event "after-show" and
"after-hide" that are based on monitoring the inner "isOpen" property
which is the one toggling the CSS visibility.

The Actions popover logic now uses "after-show" to reliably apply the
focus on the first action element.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81
    PVince81 committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    a3774bc View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Document after-show and after-hide events of Popover 

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    @PVince81
    PVince81 committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    960e91e View commit details
    Browse the repository at this point in the history