Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @nextcloud/router from 1.2.0 to 2.0.0 #1828

Merged
merged 2 commits into from
May 10, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 8, 2021

Bumps @nextcloud/router from 1.2.0 to 2.0.0.

Changelog

Sourced from @​nextcloud/router's changelog.

2.0.0 - 2021-04-07

Changed

  • generateOcsUrl can now replace routing parameters like generateUrl
  • generateOcsUrl no longer contains a trailing slash unless given in the URL
  • Browserslist config updated, which means some older browsers are no longer supported
  • Dependency updates
Commits
  • 4c0b7a9 v2.0.0
  • b8fb765 Merge pull request #213 from nextcloud/dependabot/npm_and_yarn/babel/cli-7.13.14
  • a60cff6 Merge pull request #212 from nextcloud/dependabot/npm_and_yarn/babel/core-7.1...
  • fcbe75e Merge pull request #211 from nextcloud/dependabot/npm_and_yarn/core-js-3.10.0
  • e8db5a5 Bump @​babel/cli from 7.13.10 to 7.13.14
  • 6ebcd05 Bump @​babel/core from 7.13.13 to 7.13.14
  • e021512 Bump core-js from 3.9.1 to 3.10.0
  • 4eddff4 Merge pull request #210 from nextcloud/feature/194/ocs-url-parameters
  • 7485bfc Improve documentation
  • 1996e60 Allow to provide/inject URL parameters on OCS urls too
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added 3. to review Waiting for reviews dependencies Pull requests that update a dependency file labels Apr 8, 2021
@raimund-schluessler raimund-schluessler added this to the 4.0.0 milestone Apr 8, 2021
@raimund-schluessler raimund-schluessler added the breaking PR that requires a new major version label Apr 10, 2021
@raimund-schluessler
Copy link
Contributor

@skjnldsv Since #1816 is merged, shall we merge this too?

@skjnldsv
Copy link
Contributor

@skjnldsv Since #1816 is merged, shall we merge this too?

This require fixes, but yes

@raimund-schluessler
Copy link
Contributor

This seems to break at least the Avatar component. I guess we need to check all occurences of generateOcsUrl and add the trailing slash if required.

At least here it is necessary:
https://github.com/nextcloud/nextcloud-vue/blob/master/src/mixins/userStatus.js#L57

@raimund-schluessler
Copy link
Contributor

Should be good now.

src/mixins/userStatus.js Outdated Show resolved Hide resolved
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler force-pushed the dependabot/npm_and_yarn/nextcloud/router-2.0.0 branch from e834431 to 8d3f53e Compare May 10, 2021 09:32
@skjnldsv skjnldsv merged commit dc19014 into master May 10, 2021
@skjnldsv skjnldsv deleted the dependabot/npm_and_yarn/nextcloud/router-2.0.0 branch May 10, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews breaking PR that requires a new major version dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants