Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new named slot syntax #2160

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Use new named slot syntax #2160

merged 1 commit into from
Aug 6, 2021

Conversation

raimund-schluessler
Copy link
Contributor

This PR makes sure we don't use the deprecated named / scoped slot syntax in the library anymore, see https://vuejs.org/v2/guide/components-slots.html#Deprecated-Syntax

This is a necessary preparation for migrating to vue@3 and is supported in vue@2.6 already, so nothing will break. See https://v3.vuejs.org/guide/migration/migration-build.html#preparations

Related to #2154.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler marked this pull request as ready for review August 5, 2021 20:49
@raimund-schluessler raimund-schluessler added this to the 4.0.4 milestone Aug 5, 2021
@skjnldsv skjnldsv merged commit 4a07be9 into master Aug 6, 2021
@skjnldsv skjnldsv deleted the fix/noid/slot-style branch August 6, 2021 05:53
@raimund-schluessler raimund-schluessler removed this from the 4.0.4 milestone Aug 6, 2021
julien-nc pushed a commit that referenced this pull request Sep 13, 2021
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants