Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set sidebar tab content height to be 100 percent #2431

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Set sidebar tab content height to be 100 percent #2431

merged 1 commit into from
Jan 6, 2022

Conversation

kiranparajuli589
Copy link
Contributor

Fixes #2430

@raimund-schluessler raimund-schluessler added this to the 5.0.0 milestone Jan 4, 2022
@raimund-schluessler
Copy link
Contributor

I briefly checked with

  • Files
  • Talk
  • Photos
  • Calendar
  • Tasks
  • Deck

Adding height: 100% seems to be fine.

@kiranparajuli589
Added height as 100 percent
87e1ac8 
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component labels Jan 5, 2022
skjnldsv
skjnldsv approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@raimund-schluessler raimund-schluessler merged commit 25f2201 into nextcloud-libraries:master Jan 6, 2022
@kiranparajuli589 kiranparajuli589 deleted the patch-1 branch January 9, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

App sidebar tab content height does not let it's child to fill the content
3 participants
@kiranparajuli589 @raimund-schluessler @skjnldsv