Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix md icon position for Actions with title #2435

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Fix md icon position for Actions with title #2435

merged 1 commit into from
Jan 6, 2022

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Jan 4, 2022 •
edited
Loading

For Actions with menu-title showing a material design icon, the icon position was off.
Before:
Screenshot 2022-01-04 at 13-55-57 Nextcloud Vue Style Guide

After:
Screenshot 2022-01-04 at 14-01-27 Nextcloud Vue Style Guide

@raimund-schluessler
Fix md icon position for Actions with title
eebaf90 
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler added bug Something isn't working feature: actions Related to the actions components labels Jan 4, 2022
@raimund-schluessler raimund-schluessler added this to the 5.0.0 milestone Jan 4, 2022
@raimund-schluessler
Copy link
Contributor Author

/backport to stable4

@raimund-schluessler raimund-schluessler added the 3. to review Waiting for reviews label Jan 4, 2022
@raimund-schluessler raimund-schluessler self-assigned this Jan 4, 2022
GretaD
GretaD approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code look good, didnt test it

@artonge
Copy link
Contributor

artonge commented Jan 4, 2022

Does this still work with non material design icons? not sure if they are still used or not.

@raimund-schluessler
Copy link
Contributor Author

Does this still work with non material design icons? not sure if they are still used or not.

Checkout the netlify docs: https://deploy-preview-2435--nextcloud-vue-components.netlify.app/#/Components/Actions?id=actions-1

It should work with non material design icons (provided via default-icon prop) and with material design icons provided by the icon slot.

The problem fixed by this PR was not visible in the docs, because we don't have an example with menu-title and md icon there.

@raimund-schluessler raimund-schluessler mentioned this pull request Jan 5, 2022
Merged
@raimund-schluessler raimund-schluessler merged commit c32ab13 into master Jan 6, 2022
@raimund-schluessler raimund-schluessler deleted the fix/noid/md-icon-actions branch January 6, 2022 14:30
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@GretaD GretaD GretaD approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@raimund-schluessler raimund-schluessler

Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raimund-schluessler @artonge @GretaD