-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aria label to the ActionInput component #2472
Add aria label to the ActionInput component #2472
Conversation
ActionInput has been extended with attribute "aria-label" Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be required. v-bind="$attrs"
should foward every other prop on ActionInput
, as stated on https://nextcloud-vue-components.netlify.app/#/Components/Actions?id=actioninput
@tcitworld thanks for you mesage! |
Indeed, so shouldn't we add |
@tcitworld it is a good idea, but this component includes also the behavior of DatetimePicker and Multiselect, and if i reject the inheritance - it could break the behavior of this components. This library will be used in different projects, and i can't be sure that it will still work well |
In that case we need to update the docs
|
/** | ||
* aria-label attribute of the input field | ||
*/ | ||
ariaLabel: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prop 'ariaLabel' requires default value to be set
the linter wants a default value ;-)
attribute "aria-label" has empty default value Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comments are delivered
resolve nextcloud/calendar#3932
ActionInput has been extended with attribute "aria-label"
Signed-off-by: julia.kirschenheuter julia.kirschenheuter@nextcloud.com