-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase the small modal width #2496
Conversation
Signed-off-by: szaimen <szaimen@e.mail.de>
Looks good, but max-width is 100% while max-height is 90% – those should probably be the same, right? Could do 90% (or 95% if needed) on both so it's still a modal-type. Also @marcoambrosini this is the fix we talked about for the Talk modals. :) |
Not sure about this. I had mobile devices in mind where having as much width as possible is probably desired? But I guess 95% should be fine. What do you think? |
We do full width/height for the other ones, but for the small size max 95% to have a little bit of modal-ness would be good. :) |
fine by me then |
Signed-off-by: szaimen <szaimen@e.mail.de>
@marcoambrosini could you give your 👍 if it looks fine to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goood :)
Signed-off-by: szaimen szaimen@e.mail.de