Adjust loading icon style, replace fillColor prop
#2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raimund-schluessler
force-pushed
the
fix/2777/loading-icon-style
branch
from
322fb21
to
66e791e
Compare
This was
linked to
issues
Jul 22, 2022
raimund-schluessler
added
enhancement
raimund-schluessler
requested review from
jancborchardt,
skjnldsv,
marcoambrosini,
nimishavijay and
GretaD
raimund-schluessler
added
3. to review
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/2777/loading-icon-style
branch
from
66e791e
to
e036e2a
Compare
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
marcoambrosini
approved these changes
Jul 24, 2022
|
just a heads up |
juliushaertl
approved these changes
Jul 27, 2022
|
Thanks a lot @raimund-schluessler! Good on using the existing style – not only for consistency reasons with apps which didnt adopt it yet, but also cause that loading icon without full circle is not core Material Design, but a community icon from materialdesignicons.com vs being from https://material.io/icons How you now fixed it (and how it looked like) looks very nice, and is also used by lots of other platforms like e.g. Twitter or Twitch. :) |
jancborchardt
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the style of the vue loading icon to the old style of the loading icon:
It also replaces the
fillColorwith anappearanceprop. This prevents the usage of arbitrary colors, and allows to select whether the icon adjusts its color to the Nextcloud color scheme, or always shows aslightordark, independent of the color scheme.At the moment, the colors for the
lightanddarkmode are hard-coded, since I didn't find any color variables that don't change with the color scheme. Any hints here are welcome.Follow-up to #2727.