Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more explicit title to the sidebar close button #2894

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Add more explicit title to the sidebar close button #2894

merged 1 commit into from
Jul 27, 2022

Conversation

juliusknorr
Copy link
Contributor

To make sure that a screen reader user has some context on what the button actually does

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities labels Jul 27, 2022
raimund-schluessler
raimund-schluessler previously requested changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs l10n extract.

@juliusknorr
Add more explicit title to the sidebar close button
778bb76 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/close-sidebar-label branch from 1c267d3 to 778bb76 Compare July 27, 2022 14:22
@juliusknorr juliusknorr added this to the 6.0.0 milestone Jul 27, 2022
@juliusknorr juliusknorr merged commit 22476f9 into master Jul 27, 2022
@juliusknorr juliusknorr deleted the bugfix/noid/close-sidebar-label branch July 27, 2022 16:59
@juliusknorr juliusknorr mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@artonge artonge artonge approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusknorr @raimund-schluessler @artonge @marcoambrosini