Fix reference to closed menu in "aria-controls" #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "aria-controls" attribute must point to an element in the same document. When the menu is closed it is removed from the DOM, so the "aria-controls" attribute should be set only when the menu is open. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
bug
raimund-schluessler
approved these changes
Aug 14, 2022
raimund-schluessler
requested review from
JuliaKirschenheuter,
skjnldsv and
marcoambrosini
marcoambrosini
approved these changes
Aug 16, 2022
raimund-schluessler
deleted the
fix-reference-to-closed-menu-in-aria-controls
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2842
The
aria-controlsattribute must point to an element in the same document. When the menu is closed it is removed from the DOM, so thearia-controlsattribute should be set only when the menu is open.According to MDN The
aria-controlsonly needs to be set when the popup is visible, so I guess it is fine to remove it if the menu is not there rather than always having it in the DOM but hidden, although I do not really know.