Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slot for dot indicator in NcListItem.vue #3132

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Add slot for dot indicator in NcListItem.vue #3132

merged 1 commit into from
Aug 31, 2022

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Aug 31, 2022 •
edited
Loading

Required for nextcloud/mail#6982

Screenshots:
image
image

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Aug 31, 2022
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Aug 31, 2022
@raimund-schluessler
Copy link
Contributor

@JuliaKirschenheuter Could you please add an example to the docs how to use the indicator slot?

@raimund-schluessler
Copy link
Contributor

Wouldn't it make sense to put the indicator in line two, next to the counter, instead of creating a list-item-content__secondary element and leaving the rest untouched? Judging from the mockup in nextcloud/mail#6982 this seems most fitting.

@ChristophWurst ChristophWurst mentioned this pull request Aug 31, 2022
Merged
2 tasks
@JuliaKirschenheuter
Copy link
Contributor Author

Wouldn't it make sense to put the indicator in line two, next to the counter, instead of creating a list-item-content__secondary element and leaving the rest untouched? Judging from the mockup in nextcloud/mail#6982 this seems most fitting.

You are right, thanks for your feedback!

jancborchardt
jancborchardt approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :)

@JuliaKirschenheuter
Add slot for dot indicator in NcListItem.vue
74d6ad5 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the enh/6982-show_primary_color_dot_in_subject_line_for_unread_messages_in_envelope_list branch from a9df240 to 74d6ad5 Compare August 31, 2022 14:26
GretaD
GretaD approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JuliaKirschenheuter JuliaKirschenheuter merged commit 3ae7b9b into master Aug 31, 2022
@JuliaKirschenheuter JuliaKirschenheuter deleted the enh/6982-show_primary_color_dot_in_subject_line_for_unread_messages_in_envelope_list branch August 31, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@st3iny st3iny Awaiting requested review from st3iny

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JuliaKirschenheuter @raimund-schluessler @jancborchardt @GretaD