Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a word puzzle in NcDashboardWidget component #3225

Merged
merged 1 commit into from
Sep 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions l10n/messages.pot
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,10 @@ msgstr ""
msgid "Hide password"
msgstr ""

msgid "items"
msgstr ""

msgid "Message limit of {count} characters reached"
msgstr ""

msgid "More {dashboardItemType} …"
msgid "More items …"
msgstr ""

msgid "Next"
Expand Down
12 changes: 5 additions & 7 deletions src/components/NcDashboardWidget/NcDashboardWidget.vue
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,13 @@ export default {
default: '',
},
/**
* The type of elements to show more.
* The text of show more button.
*
* Expected to be in the form "More {itemName} …"
*/
showMoreText: {
showMoreLabel: {
type: String,
default: t('items'),
default: t('More items'),
},
/**
* A boolean to put the widget in a loading state.
Expand Down Expand Up @@ -307,10 +309,6 @@ export default {
showMore() {
return this.showMoreUrl && this.items.length >= this.maxItemNumber
},

showMoreLabel() {
return t('More {dashboardItemType} …', { dashboardItemType: this.showMoreText })
},
},
}
</script>
Expand Down