Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-user avatar on complex background #3272

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

ChristophWurst
Copy link
Contributor

@ChristophWurst ChristophWurst commented Sep 20, 2022

Discovered in nextcloud/contacts#2726

Due to the 0.1 alpha channel of the new avatars, the background potentially shows through. This is not expected nor does it look any good.

Before After
Bildschirmfoto vom 2022-09-20 09-16-31 Bildschirmfoto vom 2022-09-20 09-53-45

@ChristophWurst ChristophWurst added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature design Design, UX, interface and interaction design feature: avatar Related to the avatar component labels Sep 20, 2022
@ChristophWurst ChristophWurst added this to the 7.0.0 milestone Sep 20, 2022
@ChristophWurst ChristophWurst self-assigned this Sep 20, 2022
@ChristophWurst ChristophWurst force-pushed the fix/avatar-on-complex-background branch 2 times, most recently from 88afaf1 to 7bcffb5 Compare September 20, 2022 07:54
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Copy link
Contributor

@raimund-schluessler raimund-schluessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise 👍
design-wise others have to decide

@raimund-schluessler raimund-schluessler merged commit c0156cd into master Sep 20, 2022
@raimund-schluessler raimund-schluessler deleted the fix/avatar-on-complex-background branch September 20, 2022 09:54
@raimund-schluessler
Copy link
Contributor

/backport to stable6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: avatar Related to the avatar component regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants