-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-user avatar on complex background #3272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
Something isn't working
3. to review
Waiting for reviews
regression
Regression of a previous working feature
design
Design, UX, interface and interaction design
feature: avatar
Related to the avatar component
labels
Sep 20, 2022
ChristophWurst
requested review from
jancborchardt,
tcitworld,
raimund-schluessler,
GretaD and
CarlSchwan
September 20, 2022 07:42
23 tasks
ChristophWurst
force-pushed
the
fix/avatar-on-complex-background
branch
2 times, most recently
from
September 20, 2022 07:54
88afaf1
to
7bcffb5
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/avatar-on-complex-background
branch
from
September 20, 2022 08:01
7bcffb5
to
acdd3f2
Compare
raimund-schluessler
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-wise 👍
design-wise others have to decide
jancborchardt
approved these changes
Sep 20, 2022
/backport to stable6 |
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
Something isn't working
design
Design, UX, interface and interaction design
feature: avatar
Related to the avatar component
regression
Regression of a previous working feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in nextcloud/contacts#2726
Due to the 0.1 alpha channel of the new avatars, the background potentially shows through. This is not expected nor does it look any good.