-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing half-empty dashboard empty content view #3407
Merged
nickvergessen
merged 2 commits into
master
from
bugfix/noid/fix-half-empty-dashboard-view
Oct 31, 2022
Merged
Fix missing half-empty dashboard empty content view #3407
nickvergessen
merged 2 commits into
master
from
bugfix/noid/fix-half-empty-dashboard-view
Oct 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
Something isn't working
3. to review
Waiting for reviews
regression
Regression of a previous working feature
feature: dashboard
Related to the dashboard widget
labels
Oct 31, 2022
nickvergessen
requested review from
raimund-schluessler,
juliusknorr and
marcoambrosini
October 31, 2022 09:40
/backport to stable6 |
2 tasks
raimund-schluessler
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stupid mistake 🙈
danxuliu
approved these changes
Oct 31, 2022
Merged
/backport to stable7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
Something isn't working
feature: dashboard
Related to the dashboard widget
regression
Regression of a previous working feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from 8705a05#diff-3d47e5014667a3933f462ef227ec4965133bf0b3fb67e26bbd164fdda46dc006
Found while working on nextcloud/spreed#8260
Also added it to the docs:
https://deploy-preview-3407--nextcloud-vue-components.netlify.app/#/Components/NcDashboard?id=ncdashboardwidget