Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend NcInputField props and forward $attrs to NcPasswordField and NcTextField #3485

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Extend NcInputField props and forward $attrs to NcPasswordField and NcTextField #3485

merged 1 commit into from
Nov 17, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Nov 16, 2022 •
edited
Loading

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Nov 16, 2022
@skjnldsv skjnldsv added this to the 7.1.0 milestone Nov 16, 2022
@skjnldsv skjnldsv self-assigned this Nov 16, 2022
@skjnldsv skjnldsv mentioned this pull request Nov 16, 2022
Closed
@skjnldsv skjnldsv requested a review from artonge November 16, 2022 08:29
@skjnldsv skjnldsv force-pushed the feat/text-fields-simplify branch 3 times, most recently from f627065 to 20c0870 Compare November 16, 2022 08:36
nickvergessen
nickvergessen approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:electron:

ShGKme
ShGKme reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be a breaking change around minlength in NcPasswordField

src/components/NcPasswordField/NcPasswordField.vue Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/text-fields-simplify branch from de3044d to 5259a23 Compare November 16, 2022 16:26
@skjnldsv skjnldsv requested a review from ShGKme November 16, 2022 16:42
Pytal
Pytal approved these changes Nov 17, 2022
View reviewed changes
src/components/NcInputField/NcInputField.vue Outdated Show resolved Hide resolved
@skjnldsv
Extend NcInputField props and forward $attrs to NcPasswordField and N…
e0ca5cc 
…cTextField

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/text-fields-simplify branch from 5259a23 to e0ca5cc Compare November 17, 2022 07:01
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 17, 2022
@skjnldsv skjnldsv merged commit 4df40b5 into master Nov 17, 2022
@skjnldsv skjnldsv deleted the feat/text-fields-simplify branch November 17, 2022 07:14
@nickvergessen
Copy link
Contributor

/backport to stable7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 17, 2022
Closed
1 task
@skjnldsv skjnldsv mentioned this pull request Nov 18, 2022
Merged
@dartcafe dartcafe mentioned this pull request Nov 27, 2022
Closed
@susnux susnux mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Pytal approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@dartcafe dartcafe Awaiting requested review from dartcafe

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@artonge artonge Awaiting requested review from artonge

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

Extend default text fields attributes programmatically instead of defining every. single. use case.
4 participants
@skjnldsv @nickvergessen @Pytal @ShGKme